KAFKA-15145: Don't re-process records filtered out by SMTs on Kafka client retriable exceptions in AbstractWorkerSourceTask#13955
Merged
C0urante merged 2 commits intoapache:trunkfrom Jul 10, 2023
Conversation
…lient retriable exceptions in AbstractWorkerSourceTask
C0urante
reviewed
Jul 6, 2023
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
Thanks Yash, great catch! Left one thought on testing and a possible behavior change below; LMKWYT.
...ect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java
Outdated
Show resolved
Hide resolved
vamossagar12
suggested changes
Jul 7, 2023
Contributor
vamossagar12
left a comment
vamossagar12
left a comment
There was a problem hiding this comment.
Thanks for the PR. Added some minor comments/suggestions.
...ect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java
Show resolved
Hide resolved
C0urante
approved these changes
Jul 10, 2023
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
LGTM, thanks Yash!
Let me know how you feel about the re-transforming-on-retry discussion. Happy to hold off on merging if you'd like to tweak this more, but otherwise, I'm comfortable with these changes and am ready to merge+backport.
Contributor
Author
|
Thanks Chris, I agree with the point you brought up regarding potential poison pill messages. This PR can be merged. |
C0urante
pushed a commit
that referenced
this pull request
Jul 10, 2023
…lient retriable exceptions in AbstractWorkerSourceTask (#13955) Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Chris Egerton <chrise@aiven.io>
Cerchie
pushed a commit
to Cerchie/kafka
that referenced
this pull request
Jul 25, 2023
…lient retriable exceptions in AbstractWorkerSourceTask (apache#13955) Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Chris Egerton <chrise@aiven.io>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://issues.apache.org/jira/browse/KAFKA-15145:
Committer Checklist (excluded from commit message)